Eric Hanson

Results 402 comments of Eric Hanson

I think this is a big improvement over the status quo for the printing of these objects; [adding a unique identifier](https://github.com/JuliaLang/julia/pull/55239#discussion_r1692324954) would be nice, but we don't have one of...

that's a good idea, made a note here: https://github.com/ericphanson/ExplicitImports.jl/pull/109/files#r2128885216

it turns out `IdDict` does not suffice for me since I have a `Vector{SyntaxNode}` and object identity on the vector is not what I want. I think Keno's idea to...

> As for the implementation, if we make this work, it just do nothing at that point rather than actually assigning var"_". Yeah, to me that seems correct, matching `import...

> I do think import Foo as _ is cleaner in its intent to load Foo. The loading side effect of the colon-full version of using is a bit of...

ok, I think I fixed the implementation issue just by returning early like in the next branch, and I strengthened the test to verify we can do `using Foo: _`...

Yeah, it does seem like a weird special case, I agree. I think the syntax would be handy but agree that like all new syntax it deserves scrutiny and a...

btw @KZiemian let me know if this is the workflow you prefer here

no, I'm using RegistryInstances for both. It can handle both packed and unpacked registries