Eric Hanson
Eric Hanson
I don't really know this code well enough to be confident here. But one thing I can say is it's probably good if the PR adds a test that is...
FYI ExplicitImports.jl v1.5 has expanded scope a bit, and can detect some issues related to qualified names, like using `LinearAlgebra.promote_op` instead of `Base.promote_op` (they are the same function but the...
Just to say ExplicitImports v1.6 should now be able to handle the case from the OP via the new [`check_all_explicit_imports_via_owners `](https://ericphanson.github.io/ExplicitImports.jl/stable/api/#ExplicitImports.check_all_explicit_imports_via_owners), since it is an explicit import of a name...
ExplicitImports.jl 1.7 now supports Julia 1.6, so if Aqua was willing to require 1.6 instead of 1.0, it would be addable. It is harder to support older Julias like 1.0...
Yeah, here is the example from the tests. ```julia julia> using REPL julia> REPL.SHOW_MAXIMUM_BYTES = 1000 1000 julia> struct A40735 str::String end julia> str = string(('a':'z')...)^40 "abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijk" ⋯ 499 bytes...
BTW, at the very end of the printing, there's ```julia [...]tuvwxyzabcdeError showing value of type A40735: ERROR: REPL.LimitIOException: aborted printing after attempting to `show` more than 1000 bytes of data...
What would you suggest?
That sounds like a better idea. I just pushed a commit, with that I get ```julia julia> A40735(str) A40735("abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcde…[printing stopped after 1000 displaying bytes] ``` (ends with `…[printing stopped after...
I added the colored printing, ~~but the performance issue may be a showstopper here.~~