Eric Haag

Results 25 comments of Eric Haag

There are three timeouts to consider here. The first two are the `connect.timeout` and `read.timeout`. They only control the connect and read timeouts of the underlying `OkHttpClient`. https://github.com/gradle/gradle-enterprise-build-validation-scripts/blob/d3f88c728cbac9419a4ce694ade503e005d91879/components/fetch-build-scan-data-cmdline-tool/src/main/java/com/gradle/enterprise/api/client/GradleEnterpriseApiClient.java#L108-L117 The third...

A note on the design while I'm thinking about it: Using a custom value will show up as a difference in the build scan comparison, but a tag will not.

I was also advocating for a tag when I wrote that. A custom value means there will always be a difference between the builds, which could be misleading.

In general, this can happen if authentication is required to access the remote build cache (i.e. anonymous remote build cache reads are not allowed). As a workaround for this issue,...

Successfully ran the below experiments at commit 0e2028a470faa775e65c499f5a5252b70db5e33d. ``` ./01-validate-incremental-building.sh -r [email protected]:gradle/gradle-build-scan-quickstart.git -c 710a21dad423192a0ea2d9aea77f381f40eb8a6a -t 'build' -s https://ge.solutions-team.gradle.com ./02-validate-local-build-caching-same-location.sh -r [email protected]:gradle/gradle-build-scan-quickstart.git -c 710a21dad423192a0ea2d9aea77f381f40eb8a6a -t 'build' -s https://ge.solutions-team.gradle.com ./03-validate-local-build-caching-different-locations.sh -r [email protected]:gradle/gradle-build-scan-quickstart.git...

When I invoke a script I get this right at the start: ![image](https://github.com/gradle/gradle-enterprise-build-validation-scripts/assets/5797900/8153a3ef-1933-4ba4-b8d3-8dbb4fcb0a7f) Message: ```shell /Users/eric/Projects/gradle/gradle-enterprise-gradle-build-validation/local/lib/scripts/exit-code.sh: line 3: SUCCESS: readonly variable ``` To reproduce it, just run: ```shell ./01-validate-incremental-building.sh \...

This is probably an issue with the jar, but I noticed this in debug mode: ![image](https://github.com/gradle/gradle-enterprise-build-validation-scripts/assets/5797900/a146e619-724f-4892-9589-3457e2610aa3)

Did some testing and all looks good up to this point. Each distribution has their respective license and scripts are working as expected.

We could also switch to plain text mode when running with the fail if not fully cacheable flag as the main use case there is for running in CI. Unfortunately,...

@etiennestuder I want to make sure you see the note I have in the description: > The CI/Local experiments (exp5-gradle & exp4-maven) will also be invoked with -Dpts.enabled=false even if...