Eric Giovanola

Results 39 comments of Eric Giovanola

@acroyear something like the following: ```jsx const RootClose = ({ children, onRootClose, ...props }) => { const [rootElement, attachRef] = useState(null); useRootClose(rootElement, onRootClose, props); return children(attachRef); }; ``` Usage: ```jsx...

Oh sorry, I meant a PR for an actual component :)

Fwiw, using a component instead of a hook still seems valid for class-based components, as the OP notes. The main issue with the old `RootCloseWrapper` was that it relied on...

Hey @ianatha, thanks for the report. I believe this is an issue with `renderMenu` and `renderToken` as well. I'd love your help with this if you want to submit a...

@ianatha I had looked into this issue a bit and found that to be the case as well, since the option type needs to be propagated to most of the...

Thanks for taking a crack at this, @orta. If propagating the generic type throughout the codebase isn't a feasible solution, do you have any thoughts or recommendations on how consumers...

@HansAarneLiblik: I'm not sure, do you want to give it a shot? The main problem described in the thread is that to truly propagate the generic type basically involves passing...

Support for `visually-hidden` classname added in v5.2.0. @filipkis: I don't have a timeline on when full, out of the box support will happen. I'll try to add things incrementally, but...

> My conclusion was that the library must be made aware of which Bootstrap version is using. That sounds right. When BS4 came out I added a separate CSS file...

The BS5 clear button is now supported as of v6.0.0-alpha.7. Along with the existing `Typeahead.css` file, you'll also need to add the `Typeahead.bs5.css` file that is now included with the...