Eric Dallo
Eric Dallo
Probably because is not a elisp raw error, it's from parsing the json on dap buffer, @yyoncho do you know how to debug that?
Could you both test with latest lsp-dart released this week and confirm this is still happening?
Yeah, It would be great to be able to do that, @yyoncho, `dap-mode` has this support? Do you think it's hard to implement that?
@zakariaz all dap integration for lsp-dart is in `lsp-dart-dap.el` file, the rest is done by `dap-mode`, like create dynamically the `dap-dart-setup` function
Sure, here we declare the function dynamically: https://github.com/emacs-lsp/dap-mode/blob/master/dap-utils.el#L101
LGTM any concerns @yyoncho ?
@elken sorry for the delay, could you fix conflicts and the CI ?
@jcs090218 any thoughts about CI failing?
@elken Looks good to me! I'll give a little bit of more testing and then we can merge it
I meant the code review 😅 I still need to manually test it