Eric Dallo

Results 686 comments of Eric Dallo

@mainej I'd like to add that this week I noticed those freezes more frequently in my projects from my work, it's really like clijure-lsp is processing one request at time....

@mainej no worries, I'm glad we are aware and found the reason, LMK if you need any help on that investigation or help to test anything

@mainej I can confirm the really slow diagnostics + semantic tokens on Calva indeed, way slower compared with the previous release

For anyone interested on this issue, it was merged on lsp4clj and made the necessary changes on clojure-lsp so it's available on nightly builds, please let us know if any...

@borkdude it seems the issue is related with cleaning ns with `#_:clj-kondo/ignore`, clojure-lsp doesn't edit properly the requires, but if you move the ignore to top ns it does work...

I think you can ignore via clj-kondo config as another alternative for now as well

@mainej I see, should we "fix" this on rewrite-clj or at least provide a function that uses `z/edn*`? Even so, sounds good fixing the root cause instead of doing workarounds...

No, they fix different bugs, I think it's ok to merge #1251 and when we have that on rewrite-clj we change that.

I took a quick look and one problem I found is that with current clj-kondo analysis we can know if that `x` is a local or a var defined elsewhere...

@borkdude it's available (besides the symbol), but I can't see how that would help here, what we need is a way to know all undefined local-usages to allow renaming, and...