Ezra Chung

Results 15 comments of Ezra Chung

> This issue should probably be renamed. This effects all types of `using` that import declarations of entities from one namespace into another. > Which version of doxygen did you...

@jeroen Fixes have been merged in https://github.com/mongodb/mongo-c-driver/pull/1120. Please let us know if [this commit](https://github.com/mongodb/mongo-c-driver/commit/fd80583c3142fdca4f14c28d596096e341ad5fbf) resolved the issues reported.

Fixed the install-uninstall-check task by ensuring the uninstall.sh script is always executable even prior to installation. Verified by [this patch](https://spruce.mongodb.com/task/mongo_c_driver_smoke_install_uninstall_check_patch_ef17740c31eb82655ac767a8d64f9e7e3a982180_66a157377169b40007d660c6_24_07_24_19_34_20/).

Additionally removed the `find-cmake.sh` script, which appears to be unused by any of the C Driver, CXX Driver, or libmongocrypt repos.

> Building the C driver resulted in errors due to unused-parameter warnings: [...] Shouldn't [FetchMongoC.cmake](https://github.com/mongodb/mongo-cxx-driver/blob/55ad3447dbd46560eca6e99adfcf195ecd7c1c7a/cmake/FetchMongoC.cmake#L31) be preventing warnings-as-errors when building the C Driver from source?

Although not directly related, given the Catch2 migration improves trailing semicolon handling + relocation/modification of the newly-named `catch_helpers.hh` header, applied a drive-by Reduce Warnings commit that addresses 294 (174 unique)...

Per suggestions in [this comment](https://github.com/mongodb/mongo-cxx-driver/pull/1236/files#r1805302387), added support for `--filter` and `--verbose` flags, which may be used as follows: ```bash ./runner --verbose 0 # Default: no verbose. ./runner --verbose 1 #...

> the defines are now defined so they are not defined in the code anymore, this results that the define is not know in a doxygen sense Although non-intuitive, this...

Feature test macros may be defined such that they are tested with `ifdef` without any particular value: ```cpp // Library. #if /* ... configuration ... */ #define FEATURE_IS_SUPPORTED #endif ```...

To elaborate, the original `unknown define` warning is being caused by an inserted Doxygen documentation comment attempting to document an export macro provided by CMake's `generate_export_header()` command, which defines the...