tagreader-python icon indicating copy to clipboard operation
tagreader-python copied to clipboard

Tag optional or not?

Open smolvik1 opened this issue 1 year ago • 2 comments

Perhaps a silly question, but is tag an Optional parameter in search as per the type hinting or not? https://github.com/equinor/tagreader-python/blob/25743aca87f8cc0979569e756b2a445719185d16/tagreader/web_handlers.py#L444

smolvik1 avatar Jun 19 '24 06:06 smolvik1

c = tagreader.IMSClient("GFB", "aspenone") c.connect() c.search(desc='*Ringrom*')

Yields Tag is required.

Doing the same for a piwebapi client, e.g PINO, results are returned. Assuming then that the aspenone client requires the tag input when searching, whereas the piwebapi client does not.

smolvik1 avatar Jun 19 '24 06:06 smolvik1

I apologize for the late answer. Tagreader has been on the back-burner for a while as we have been tasked on different projects. Yes this is because Aspenone client requires the input tag when searching while the piwebapi does not. But I see that the typing is a bit confusing and I'll look into if we can find a better way to do it so that we don't get conflicting types.

Asgmel03 avatar Oct 22 '24 11:10 Asgmel03