ert icon indicating copy to clipboard operation
ert copied to clipboard

Disable experiment types that do parameter updates if there are no params to update

Open JHolba opened this issue 1 year ago • 2 comments

If all parameters have UPDATE:FALSE set, then we should not let the user select any mode that does parameter updates.

Issue Resolves #8970

Approach Added a check to see if any parameter has update set to true. If it fails we disable experiment types that do parameter updates.

  • [x] PR title captures the intent of the changes, and is fitting for release notes.
  • [x] Added appropriate release note label
  • [x] Commit history is consistent and clean, in line with the contribution guidelines.
  • [x] Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • [ ] When there are user facing changes: Updated documentation
  • [ ] New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • [ ] Large PR: Prepare changes in small commits for more convenient review
  • [ ] Bug fix: Add regression test for the bug
  • [ ] Bug fix: Create Backport PR to latest release

JHolba avatar Oct 21 '24 13:10 JHolba

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.74%. Comparing base (90d11ec) to head (ef654a4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9007      +/-   ##
==========================================
- Coverage   90.76%   90.74%   -0.03%     
==========================================
  Files         351      351              
  Lines       21895    21898       +3     
==========================================
- Hits        19874    19871       -3     
- Misses       2021     2027       +6     
Flag Coverage Δ
cli-tests 39.22% <71.42%> (-0.02%) :arrow_down:
gui-tests 71.73% <71.42%> (-0.01%) :arrow_down:
performance-tests 49.37% <14.28%> (+<0.01%) :arrow_up:
unit-tests 79.65% <71.42%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 21 '24 13:10 codecov-commenter

I think it would be nice to write a test for this. At least the ErtCliError.

xjules avatar Oct 22 '24 07:10 xjules

Looks nice @JHolba ! Just had a smaller comment on testing all update experiments in the gui test.

xjules avatar Nov 11 '24 12:11 xjules