ert icon indicating copy to clipboard operation
ert copied to clipboard

RuntimeInfo added to storage

Open lars-petter-hauge opened this issue 1 year ago • 2 comments

RuntimeInfo represents information related to a job that has been submitted, it does not include anything afterwards (such as loading results). Resubmitting will not overwrite, rather append for each submit

Issue Resolves #8046

  • [x] PR title captures the intent of the changes, and is fitting for release notes.
  • [x] Added appropriate release note label
  • [x] Commit history is consistent and clean, in line with the contribution guidelines.
  • [x] Make sure tests pass locally (after every commit!)

lars-petter-hauge avatar Jun 03 '24 12:06 lars-petter-hauge

Codecov Report

Attention: Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.99%. Comparing base (1d111e9) to head (defdab6). Report is 11 commits behind head on main.

Files Patch % Lines
src/ert/scheduler/job.py 90.90% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8047      +/-   ##
==========================================
- Coverage   86.00%   85.99%   -0.02%     
==========================================
  Files         382      382              
  Lines       23614    23641      +27     
  Branches      635      620      -15     
==========================================
+ Hits        20309    20329      +20     
- Misses       3231     3232       +1     
- Partials       74       80       +6     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jun 03 '24 14:06 codecov-commenter

Hi! I think it is nice that we start to store this information about runtime information that has previously been stored temporarily in the client. However, I think it is not optimal that we are not using this information in ERT as well, as this lead to potentially multiple sources of the same information. Is it possible to also use this info in the clients?

sondreso avatar Jun 06 '24 08:06 sondreso

Closing this for now since there has not been any activity recently, feel free to re-open in the future!

sondreso avatar Aug 07 '24 12:08 sondreso