terraform-provider-equinix icon indicating copy to clipboard operation
terraform-provider-equinix copied to clipboard

feat: Add optional attribute tier in Create Virtual Device request for C8000V and C8000V SDWAN

Open kpdhulipala opened this issue 1 year ago • 1 comments

feat: Add optional attribute tier in Create Virtual Device request for C8000V and C8000V SDWAN

kpdhulipala avatar Sep 09 '24 16:09 kpdhulipala

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 21.73%. Comparing base (4b6af14) to head (4f629cb). Report is 19 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #771       +/-   ##
===========================================
- Coverage   34.38%   21.73%   -12.65%     
===========================================
  Files         154      109       -45     
  Lines       21080    10805    -10275     
===========================================
- Hits         7249     2349     -4900     
+ Misses      13670     8420     -5250     
+ Partials      161       36      -125     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 13 '24 20:09 codecov-commenter

A unit test is failing:

=== RUN   TestNetworkDevice_updateResourceData
    resource_network_device_test.go:141: 
        	Error Trace:	/home/runner/work/terraform-provider-equinix/terraform-provider-equinix/equinix/resource_network_device_test.go:141
        	Error:      	Expected nil, but got: &errors.errorString{s:"error reading Secondary: Invalid address to set: []string{\"secondary_device\", \"0\", \"tier\"}"}
        	Test:       	TestNetworkDevice_updateResourceData
        	Messages:   	Update of resource data does not return error
--- FAIL: TestNetworkDevice_updateResourceData (0.00s)

ctreatma avatar Sep 16 '24 18:09 ctreatma

This PR is included in version 2.10.0 :tada:

github-actions[bot] avatar Oct 31 '24 23:10 github-actions[bot]

This PR is included in version 2.11.0 :tada:

github-actions[bot] avatar Nov 16 '24 00:11 github-actions[bot]