cbindgen icon indicating copy to clipboard operation
cbindgen copied to clipboard

cbindgen MSRV

Open petreeftime opened this issue 3 years ago • 3 comments

The MSRV for cbindgen doesn't seem to be strictly adhered to:

  • The README.md file specifies the MSRV is 1.32
  • The CI indicates that the version tested is in fact 1.54
  • indexmap, a dependency of the project requires 1.56 and pulls in hashbrown, which actually requires 1.56 due to support for edition 2021

Can the requirements be made a bit clearer with regards to the MSRV?

Would it be possible to release a minor version of cbindgen that has the indexmap dependency specified in such a way that 2021 edition / 1.56 is not strictly required? You have to go back quite a bit, to 0.15 for this to be true.

petreeftime avatar Aug 01 '22 17:08 petreeftime

MSRV tested on CI was 1.40 for quite some time. Apparently it was significantly increased in https://github.com/eqrion/cbindgen/commit/d4e508d6d1c1c09b3377772b9e18318bea5ee9ae to support clap 3.

petrochenkov avatar Aug 01 '22 17:08 petrochenkov

indexmap, a dependency of the project requires 1.56 and pulls in hashbrown, which actually requires 1.56 due to support for edition 2021

Is this still a problem? I can currently build with 1.54 locally without problems.

Can the requirements be made a bit clearer with regards to the MSRV?

I opened a PR to adjust the MSRV specified in the README badge and the clippy.toml: https://github.com/eqrion/cbindgen/pull/816

jschwe avatar Mar 08 '23 09:03 jschwe

This issue can probably be closed since #912 was merged.

diligence5087 avatar Mar 18 '24 14:03 diligence5087