Pete Walsh

Hey @martin-kirilov, this sounds like a good feature to have. Feel free to submit a PR if you get a chance.

Something like this would be very good to have.

@tshu-w would you be interested in making a PR for this? It would also be good to include the AllenNLP version in this meta-data.

Another detail: we should make sure this meta data is included in the model archive.

Now that we're saving meta data in model archives, adding this should be pretty straightforward. We'd just need to add it to the [`Meta`](https://github.com/allenai/allennlp/blob/main/allennlp/common/meta.py) class.

@tshu-w we're going to keep this open until the feature is added. Do you still want to make a PR?

Hey @ethch18, this model was developed without the intent of making it efficient for training. And it's not on our road-map to improve this class, but we would certainly appreciate...

> For us to do that, we have to be able to save objects for which we don't have implementation code ... I'm not sure I follow this, can you...

Gotcha. And what would happen with the vocab when you call `Model.save()`? Would you have to serialize the vocab separately? Then I imagine you would have to load the vocab...

Hi @unikcc, we have a template repo for this purpose: https://github.com/allenai/allennlp-template-config-files. You could also make your own template repo if that one is not exactly what you're looking for.