Eric Pugh

Results 587 comments of Eric Pugh

@jzonthemtn did open https://issues.apache.org/jira/browse/OPENNLP-1515, but that will require a release of OpenNLP before we can piggy back on it

I think the first draft is done, and it "works". There are some caveats and things to be figured out, like the `onnxruntime_gpu` versus `onnxruntime` issue. Based on my work...

> Looks like a great first step! Glad that OpenNLP 2.3.1 helped move it along. I did a community demo yesterday, and it went well. Having 2.3.1 meant I could...

@cpoerschke when I demoed this code at the last community meetup, @gerlowskija asked why not to commit it, and I didn't have a super great reason. I'd love your thoughts...

Looking at these build failures and the error message generated, it appears that it may be caused by us using Java 11 and OpenNLP being compiled with Java 17?? ```...

Feels like what we should be doing is having Solr 10 target Java 17 since Lucene 10 will require it, and then this code goes on Solr 10, but not...

Lucene 9 requires older version of Java than the minimum required version that OpenNLP requires. That means that this PR is pending a release of Lucene 10, and the adoption...

I updated this PR with main, to see what happened, and we're closer. Things that I think are still holding us back: 1) Solr Main is NOT on Lucene 10,...

Yep, need to wait for Lucene 10, otherwise we get some unit test failures: ``` gradlew test --tests TestOpenNLPExtractNamedEntitiesUpdateProcessorFactory.testExtractFieldRegexReplaceAll -Dtests.seed=F5DD0B40AC590A66 -Dtests.locale=pt-GW -Dtests.timezone=PRT -Dtests.asserts=true -Dtests.file.encoding=UTF-8 ``` ``` > java.lang.NoSuchMethodError: 'opennlp.tools.util.Span[] opennlp.tools.sentdetect.SentenceDetectorME.sentPosDetect(java.lang.String)'...