Eric Pugh
Eric Pugh
it this PR maybe just going down the wrong approach? I'm not wedded to this one, it felt a bit werid to me as well.
I was on the wrong branch, and just was testing out ` java.lang.AssertionError: One of the overrides of setUp does not propagate the call.` these as well... `ModuleUtilsTest` ran fine...
Okay, this time things ran! Thanks for the fixes @risdenk
Going to merge this after #947 gets in I think!
@lsarni check out PR #5 which deals with your NER classifier issue. I'm going to update the Solr next...
I will give this a stab... so the idea is to add two seperate options, the deprecated one as described above and the non deprecated one...?
So, one thing I didn't love is that now I get duplicated options when I run my `-h` command. Here is the output, and you can see the deprecated `zkHost`...
One more wrinkle in having the seperate options is that we need to remember to check both... We look up zkhost like this: ``` String zkHost = cli.getOptionValue("z"); ``` and...
> > One more wrinkle in having the seperate options is that we need to remember to check both... > > I think that's fair, an application should decide what...
Okay, so I did: ``` String zkHost = cli.hasOption("z") ? cli.getOptionValue("z") : cli.getOptionValue("zkHost"); ``` And I see deprecation message: ``` [ Deprecated for removal since 9.6 option: zkHost zkHost [ARG]...