Sebastian "Sebbie" Silbermann

Results 659 comments of Sebastian "Sebbie" Silbermann
trafficstars

> This PR doesn't require migrations Isn't the point to catch accidentally passing unmemoized objects? In those cases people do need to migrate to make the new types happy, right?

Proofing out a codemod is a requirement for this PR to get merged. Otherwise a lot of codebases will be left behind if they can't reasonably upgrade. Though this PR...

> Any update on when this issue may be resolved and how it will impact the R19 release schedule? https://github.com/facebook/react/issues/29898#issuecomment-2168472355 is still the latest.

It's still being worked on. Since the original change was part of the Canary release for so long, a lot of changes were built on top of it. Changing this...

Fixed in https://github.com/facebook/react/pull/28773. Will be released alongside React 19 as stable. You can use it today by install `eslint-plugin-react-hooks@rc`.

* **#71909** * **#71940** * **#71908** 👈 * **#71821** * **#71820** * **#71877** * `canary` This stack of pull requests is managed by Graphite. Learn more about stacking. Join @eps1lon...

### Merge activity * **Oct 29, 10:57 AM GMT+1**: A user merged this pull request with [Graphite](https://app.graphite.dev/github/pr/vercel/next.js/71908).

> Additionally since this change is so invasive I have implemented it in a way to maximize backward compatibility by still allowing most synchronous access. What are the known cases...

How do we opt out here? If I open a stack, I want to know where it broke. If it just runs on bottom and top, I can only guess....

> Add the new label to the PR in the middle of the stack, and force it to re-run by making a change to the commit message and re-submitting with...