scoringutils icon indicating copy to clipboard operation
scoringutils copied to clipboard

Remove the `across` argument in `summarise_scores()`

Open nikosbosse opened this issue 1 year ago • 2 comments

As discussed in #791: should we remove the across argument in summarise_scores()?

The idea is to be more opiniated about the happy path that users should take.

image

From #791:

For example, in summarize_score(), the by and across arguments are redundant, which is confusing for the user, and forces the developers to jump through extra input checking hoops. Since the transformation of one to the other, I would recommend being more opinionated, and having a single, well-documented option.

I guess democracy has spoken 🥲

nikosbosse avatar May 19 '24 09:05 nikosbosse

This was something you really liked @nikosbosse and if that is the case I think you can push back on knowing the work better than us.

The alternative I see is creating a little function that maps the current across input into something that works in by but that might be a bit tricky

seabbs avatar May 19 '24 17:05 seabbs

I liked it, but I guess sometimes you need to kill your darlings 🤷.

image

Surprisingly, I haven't used it that much as I expected.

nikosbosse avatar May 23 '24 19:05 nikosbosse