epic-stack icon indicating copy to clipboard operation
epic-stack copied to clipboard

The site.webmanifest needs a mandatory start_url

Open andrecasal opened this issue 2 years ago • 1 comments

As per MDN docs, the site.webmanifest requires a start_url so the website becomes installable.

I suggest adding "start_url": "http://localhost:3000", so users can test app installation during development.

andrecasal avatar Jun 12 '23 17:06 andrecasal

What if we move the site.webmanifest to be a resource route so the start_url can be dynamic based on the domain? That way people don't have to worry about keeping it up-to-date and it'll work for preview deploys and staging etc.

kentcdodds avatar Jun 12 '23 18:06 kentcdodds

Great idea! 👍

andrecasal avatar Jun 14 '23 13:06 andrecasal

Actually, looking at this it appears a relative URL would suffice. Maybe we can set it to ./?

kentcdodds avatar Jun 14 '23 18:06 kentcdodds

Let me try that out... It works 💪

andrecasal avatar Jun 15 '23 11:06 andrecasal