nighthawk icon indicating copy to clipboard operation
nighthawk copied to clipboard

Fortio output transform test: minimize gold files

Open oschaaf opened this issue 5 years ago • 0 comments

In our tests that ensure we are able to transform Nighthawk's native output format to Fortio's, we use rather arbitrary and large sample data, see input and the corresponding output.

In #534 we are more or less forced to propagate this into yet a new gold file, which by implication, also needs to be large and arbitrary.

Long gold files make it hard for the reader to figure out which portions actually are relevant to tests and which are just noise. It would be good to could cut these down to the minimum required to test this the expected behaviours?

Context: https://github.com/envoyproxy/nighthawk/pull/534#discussion_r489936479

oschaaf avatar Sep 17 '20 08:09 oschaaf