nighthawk icon indicating copy to clipboard operation
nighthawk copied to clipboard

Test BenchmarkHttpClientTest does not reset resource manager or setupBenchmarkclient if client_ is not null

Open wjuan-AFK opened this issue 5 years ago • 1 comments

Description:

Inside our BenchmarkHttpClient Test Code, if the client_ member is null, we have an if condition that says to not reset resource manager and not to call setupBenchmarkClient. I'm not sure what benefit this provides. I think that it is more likely to lead to confusion as to why the benchmarkClient and resourceManager wasn't setup with the passed in parameters.

Relevant Links: BenchMarkHttpClientTest

wjuan-AFK avatar Aug 12 '20 14:08 wjuan-AFK

That looks like stale code to me, +1 to axe it out.

oschaaf avatar Aug 12 '20 16:08 oschaaf