nighthawk icon indicating copy to clipboard operation
nighthawk copied to clipboard

Customizable request source without RPC

Open wjuan-AFK opened this issue 5 years ago • 1 comments

Issue

If a customer wants to connect to multiple clusters via the same load balancer instance, it may be difficult to do so with the #current request source implementation. A separate request source grpc server is required, and it introduces two extra connections between the test controller and the rpc Request Source and between the rpc Request Source and the Nighthawk Traffic Generator and is a potential bottleneck. Looking for a solution that allows request sources to be more easily customizable and is internal to the Nighthawk Traffic generator.

Potential solution

Refactor the nighthawk request source implementation to support a plugin infrastructure. This way a request source can be implemented internally to nighthawk and chosen at runtime. We should keep backwards compatibility with gRPC request source instances.

wjuan-AFK avatar Jun 04 '20 18:06 wjuan-AFK

FWIW This sounds awesome to me. New request sources may also bring in new dependencies, and the proposed approach here would be a great way to allow people to opt out of that when consuming NH in projects. +1

oschaaf avatar Jun 04 '20 21:06 oschaaf