nighthawk icon indicating copy to clipboard operation
nighthawk copied to clipboard

Update HDR_HISTOGRAM_C_VERSION 0.11.2 -> 0.11.8

Open oschaaf opened this issue 5 months ago • 5 comments

Some source file locations changed, hence this comes with changes to reflect that.

oschaaf avatar Jun 18 '25 20:06 oschaaf

So the tsan test failed on "//test:service_test" I can't surface the details yet from https://mordenite.cluster.engflow.com/invocations/default/fbf47dbf-216e-41c4-8610-49961bb61e89#console

It looks like either a process is hanging, or details are still being uploaded. I feel it would be good to see if this is a flake induced by slowish test execution, or an actual tsan-flagged new issue introduced via this update.

oschaaf avatar Jun 18 '25 21:06 oschaaf

So the tsan test failed on "//test:service_test" I can't surface the details yet from https://mordenite.cluster.engflow.com/invocations/default/fbf47dbf-216e-41c4-8610-49961bb61e89#console

It looks like either a process is hanging, or details are still being uploaded. I feel it would be good to see if this is a flake induced by slowish test execution, or an actual tsan-flagged new issue introduced via this update.

I don't know if you could see this already, but it looks like it was just a timeout:

[35mWARNING: [0moption '--test_timeout' was expanded to from both option '--config=clang-tsan' (source command line options) and option '--config=clang-tsan' (source command line options)
[32mINFO: [0mInvocation ID: fbf47dbf-216e-41c4-8610-49961bb61e89
[35mWARNING: [0mThe background upload of the Build Event Protocol for the previous invocation failed to complete in 5.000 seconds. Cancelling and starting a new invocation...
[32mINFO: [0mStreaming build results to: https://mordenite.cluster.engflow.com/invocation/fbf47dbf-216e-41c4-8610-49961bb61e89
[35mWARNING: [0moption '--test_timeout' was expanded to from both option '--config=clang-tsan' (source command line options) and option '--config=clang-tsan' (source command line options)
[32mINFO: [0mAnalyzed 140 targets (0 packages loaded, 0 targets configured).

eric846 avatar Jun 18 '25 21:06 eric846

So the tsan test failed on "//test:service_test" I can't surface the details yet from https://mordenite.cluster.engflow.com/invocations/default/fbf47dbf-216e-41c4-8610-49961bb61e89#console It looks like either a process is hanging, or details are still being uploaded. I feel it would be good to see if this is a flake induced by slowish test execution, or an actual tsan-flagged new issue introduced via this update.

I don't know if you could see this already, but it looks like it was just a timeout:

�[35mWARNING: �[0moption '--test_timeout' was expanded to from both option '--config=clang-tsan' (source command line options) and option '--config=clang-tsan' (source command line options)
�[32mINFO: �[0mInvocation ID: fbf47dbf-216e-41c4-8610-49961bb61e89
�[35mWARNING: �[0mThe background upload of the Build Event Protocol for the previous invocation failed to complete in 5.000 seconds. Cancelling and starting a new invocation...
�[32mINFO: �[0mStreaming build results to: https://mordenite.cluster.engflow.com/invocation/fbf47dbf-216e-41c4-8610-49961bb61e89
�[35mWARNING: �[0moption '--test_timeout' was expanded to from both option '--config=clang-tsan' (source command line options) and option '--config=clang-tsan' (source command line options)
�[32mINFO: �[0mAnalyzed 140 targets (0 packages loaded, 0 targets configured).

Actually, going to the slightly different link in that message, it claims it's still running. This CI may be brand-new as of today (see https://github.com/envoyproxy/nighthawk/pull/1251) so there might be some surprises.

eric846 avatar Jun 18 '25 22:06 eric846

I re-ran the failed tsan job; as state didn't change overnight. Let's see what happens.

oschaaf avatar Jun 19 '25 08:06 oschaaf

Allright, tsan passed on the second attempt.

oschaaf avatar Jun 19 '25 09:06 oschaaf