gateway icon indicating copy to clipboard operation
gateway copied to clipboard

api: remove enum validation on ALPNProtocol

Open zirain opened this issue 5 months ago • 3 comments

This will allow us to config that ALPNProtocol when trying to integrate other OSS project(e.g. Istio).

zirain avatar Jun 17 '25 07:06 zirain

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 71.03%. Comparing base (bb3f4ba) to head (db8db9c). :warning: Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6330      +/-   ##
==========================================
+ Coverage   71.02%   71.03%   +0.01%     
==========================================
  Files         226      226              
  Lines       40037    40037              
==========================================
+ Hits        28435    28440       +5     
+ Misses       9920     9915       -5     
  Partials     1682     1682              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 17 '25 07:06 codecov[bot]

If we don't have a validation, can we still keep a comment outlining the "typical" values http/1.0;http/1.1;h2 that most users should choose from?

guydc avatar Jun 17 '25 11:06 guydc

typical

it's there:

        // ALPNProtocols supplies the list of ALPN protocols that should be
	// exposed by the listener or used by the proxy to connect to the backend.
	// Defaults:
	// 1. HTTPS Routes: h2 and http/1.1 are enabled in listener context.
	// 2. Other Routes: ALPN is disabled.
	// 3. Backends: proxy uses the appropriate ALPN options for the backend protocol.
	// When an empty list is provided, the ALPN TLS extension is disabled.
	// Typical Supported values are:
	// - http/1.0
	// - http/1.1
	// - h2
	//
	// +optional

zirain avatar Jun 17 '25 23:06 zirain

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

github-actions[bot] avatar Jul 18 '25 00:07 github-actions[bot]