gateway icon indicating copy to clipboard operation
gateway copied to clipboard

feat(translator): http2 upstream settings

Open guydc opened this issue 1 year ago • 2 comments

What this PR does / why we need it:

  • Exposes HTTP2 settings for upstream in Backend Traffic Policy
  • Apply by default envoy's secure-by-default values for HTTP2: https://www.envoyproxy.io/docs/envoy/latest/configuration/best_practices/edge
  • Adds support for the envoy override_stream_error_on_invalid_http_message option which is specifically relevant for L2 envoy deployments running http2: https://www.envoyproxy.io/docs/envoy/latest/configuration/best_practices/level_two

Which issue(s) this PR fixes: Fixes #3670, #3245 Related to #1048

guydc avatar Jun 26 '24 22:06 guydc

Codecov Report

Attention: Patch coverage is 71.95122% with 23 lines in your changes missing coverage. Please review.

Project coverage is 67.61%. Comparing base (c2c705b) to head (f8ea793). Report is 1 commits behind head on main.

Files Patch % Lines
internal/gatewayapi/http.go 62.16% 14 Missing :warning:
internal/gatewayapi/backendtrafficpolicy.go 50.00% 4 Missing and 2 partials :warning:
internal/xds/translator/listener.go 40.00% 2 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3682      +/-   ##
==========================================
+ Coverage   67.59%   67.61%   +0.01%     
==========================================
  Files         183      184       +1     
  Lines       22446    22521      +75     
==========================================
+ Hits        15173    15227      +54     
- Misses       6193     6212      +19     
- Partials     1080     1082       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 26 '24 23:06 codecov[bot]

/retest

guydc avatar Jun 27 '24 16:06 guydc

/retest

guydc avatar Jul 26 '24 15:07 guydc

/retest

guydc avatar Jul 31 '24 13:07 guydc

/retest

guydc avatar Aug 01 '24 00:08 guydc

/retest

guydc avatar Aug 02 '24 15:08 guydc

/retest

guydc avatar Aug 02 '24 18:08 guydc

/retest

guydc avatar Aug 02 '24 19:08 guydc

/retest

guydc avatar Aug 05 '24 12:08 guydc