gateway icon indicating copy to clipboard operation
gateway copied to clipboard

Tweaking overload settings in gateway api?

Open nezdolik opened this issue 1 year ago • 5 comments
trafficstars

Description: Since overload manager config is not part of Envoy gateway api and cannot be patched via Envoy patch policy, how could one tweak values for global max downstream connections (except of having to provide custom bootstrap config)?

[optional Relevant Links:]

Any extra documentation required to understand the issue.

nezdolik avatar Jun 13 '24 09:06 nezdolik

its currently set to 50K https://github.com/envoyproxy/gateway/pull/3082, any alternate values in mind ? hoping we we pick a sane default here, and we can provide an API field in https://gateway.envoyproxy.io/v1.0.1/api/extension_types/#envoyproxy to support modifying it for edge cases

arkodg avatar Jun 13 '24 22:06 arkodg

@arkodg 50k is good default value, but the actual value very much depends on prod features enabled in the proxy. E.g. at my previous workplace Envoy instance performance was 10x times lower compared to official benchmarks due to custom Java sidecar for ext authz.

nezdolik avatar Jun 14 '24 14:06 nezdolik

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

github-actions[bot] avatar Jul 14 '24 16:07 github-actions[bot]

+1 to making overload manager more configurable.

guydc avatar Aug 19 '24 22:08 guydc

community meeting notes:

  • bootstrap config can be modified with https://github.com/envoyproxy/gateway/blob/0926b38a5abff4d19546bbe780136db5cba2a80a/api/v1alpha1/envoyproxy_types.go#L361
  • The current merge capabilities are limited when it comes to lists: https://github.com/envoyproxy/gateway/issues/3691 Since overload manager config is essentially a list of resourceMonitors, the current implementation would not work.
  • We probably need to support something like jsonpatch here

guydc avatar Aug 21 '24 22:08 guydc

@nezdolik Now that #4116 has been merged, is it possible to modify the overload manager configuration as you need it via a JSONPatch?

liorokman avatar Sep 05 '24 13:09 liorokman

@liorokman thanks for heads up, I will check tomorrow and report back.

nezdolik avatar Sep 09 '24 18:09 nezdolik

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

github-actions[bot] avatar Oct 09 '24 20:10 github-actions[bot]

@liorokman tried patching overload settings in bootstrap this week and it worked well.

nezdolik avatar Dec 06 '24 14:12 nezdolik

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

github-actions[bot] avatar Jan 05 '25 20:01 github-actions[bot]