gateway
gateway copied to clipboard
Tweaking overload settings in gateway api?
Description: Since overload manager config is not part of Envoy gateway api and cannot be patched via Envoy patch policy, how could one tweak values for global max downstream connections (except of having to provide custom bootstrap config)?
[optional Relevant Links:]
Any extra documentation required to understand the issue.
its currently set to 50K https://github.com/envoyproxy/gateway/pull/3082, any alternate values in mind ? hoping we we pick a sane default here, and we can provide an API field in https://gateway.envoyproxy.io/v1.0.1/api/extension_types/#envoyproxy to support modifying it for edge cases
@arkodg 50k is good default value, but the actual value very much depends on prod features enabled in the proxy. E.g. at my previous workplace Envoy instance performance was 10x times lower compared to official benchmarks due to custom Java sidecar for ext authz.
This issue has been automatically marked as stale because it has not had activity in the last 30 days.
+1 to making overload manager more configurable.
community meeting notes:
- bootstrap config can be modified with https://github.com/envoyproxy/gateway/blob/0926b38a5abff4d19546bbe780136db5cba2a80a/api/v1alpha1/envoyproxy_types.go#L361
- The current merge capabilities are limited when it comes to lists: https://github.com/envoyproxy/gateway/issues/3691
Since overload manager config is essentially a list of
resourceMonitors, the current implementation would not work. - We probably need to support something like jsonpatch here
@nezdolik Now that #4116 has been merged, is it possible to modify the overload manager configuration as you need it via a JSONPatch?
@liorokman thanks for heads up, I will check tomorrow and report back.
This issue has been automatically marked as stale because it has not had activity in the last 30 days.
@liorokman tried patching overload settings in bootstrap this week and it worked well.
This issue has been automatically marked as stale because it has not had activity in the last 30 days.