gateway icon indicating copy to clipboard operation
gateway copied to clipboard

design: Wasm extension supports OCI image code source

Open zhaohuabing opened this issue 1 year ago • 5 comments

Related: https://github.com/envoyproxy/gateway/issues/3304

zhaohuabing avatar May 01 '24 01:05 zhaohuabing

I'm not sure which is a better idea:

  1. extend EG controller support this
  2. introduce an new component.

zirain avatar May 01 '24 01:05 zirain

Is there potential for a new component to be reused by other envoy control planes (e.g. istio)? If so, it could be beneficial from long-term maintenance perspective...

Can we implement this based on some existing OCI registry cache?

guydc avatar May 01 '24 11:05 guydc

Is there potential for a new component to be reused by other envoy control planes (e.g. istio)? If so, it could be beneficial from long-term maintenance perspective...

To simplify the process, I'd like to create this component as part of EG rather than a standalone binary. This will help us avoid unnecessary dependencies/management(install, upgrade,etc.) overhead.

Can we implement this based on some existing OCI registry cache?

We can use https://github.com/google/go-containerregistry

zhaohuabing avatar May 01 '24 16:05 zhaohuabing

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

github-actions[bot] avatar Jun 06 '24 20:06 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.97%. Comparing base (d5fde3e) to head (0ba441c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3313   +/-   ##
=======================================
  Coverage   68.97%   68.97%           
=======================================
  Files         176      176           
  Lines       21731    21731           
=======================================
  Hits        14989    14989           
  Misses       5662     5662           
  Partials     1080     1080           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 28 '24 23:06 codecov[bot]