gateway icon indicating copy to clipboard operation
gateway copied to clipboard

feat: Reconcile BackendRefs on EnvoyProxy

Open davidalger opened this issue 1 year ago • 3 comments

What this PR does / why we need it:

This adds support for BackendRefs on EnvoyProxies to the reconciler so the same endpoint discovery used for HTTPRoute refs will be used rather than DNS based discovery using service FQDNs.

davidalger avatar Apr 15 '24 02:04 davidalger

Codecov Report

Attention: Patch coverage is 61.76471% with 91 lines in your changes missing coverage. Please review.

Project coverage is 66.65%. Comparing base (29946b0) to head (8491367). Report is 336 commits behind head on main.

:exclamation: Current head 8491367 differs from pull request most recent head e6040b2

Please upload reports for the commit e6040b2 to get more accurate results.

Files Patch % Lines
internal/provider/kubernetes/controller.go 25.86% 37 Missing and 6 partials :warning:
internal/provider/kubernetes/indexers.go 17.94% 30 Missing and 2 partials :warning:
internal/gatewayapi/listener.go 89.41% 7 Missing and 2 partials :warning:
internal/provider/kubernetes/predicates.go 72.00% 7 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3190      +/-   ##
==========================================
+ Coverage   66.51%   66.65%   +0.14%     
==========================================
  Files         161      162       +1     
  Lines       22673    22962     +289     
==========================================
+ Hits        15080    15306     +226     
- Misses       6720     6781      +61     
- Partials      873      875       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 16 '24 20:04 codecov[bot]

/retest

davidalger avatar Apr 16 '24 20:04 davidalger

hey @davidalger @zirain, just realized that there's a massive overlap with this PR and https://github.com/envoyproxy/gateway/pull/3293 , is this anything from this PR that is still required ?

arkodg avatar May 23 '24 23:05 arkodg

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

github-actions[bot] avatar Jun 23 '24 00:06 github-actions[bot]