gateway icon indicating copy to clipboard operation
gateway copied to clipboard

Published 20 hours ago • verified publisher icon envoyproxy

enhancement: use IfNotPresent for versioned helm chart release

Open networkhermit opened this issue 1 year ago • 4 comments

Description:

Most versioned helm chart in the wild default to IfNotPresent for imagePullPolicy, versioned helm chart uses tagged image so it rarely change, and change the default is good for air gapped environment.

[optional Relevant Links:] https://github.com/envoyproxy/gateway/blob/231b3b476bb897b9679f7e303904e8a4e9cc3999/charts/gateway-helm/values.tmpl.yaml#L6

networkhermit avatar Apr 12 '24 13:04 networkhermit

This looks good, what do you think? @zirain

ShyunnY avatar Apr 15 '24 04:04 ShyunnY

2 options here

  • change it to IfNotPresent only for pinned releases
  • set the default to IfNotPresent and change it to Always for v0.0.0-latest

ptal @envoyproxy/gateway-maintainers

arkodg avatar Apr 15 '24 06:04 arkodg

+1 for set the default to IfNotPresent and change it to Always for v0.0.0-latest.

guydc avatar Apr 16 '24 21:04 guydc

+1 for set the default to IfNotPresent and change it to Always for v0.0.0-latest.

zhaohuabing avatar Apr 17 '24 05:04 zhaohuabing