gateway icon indicating copy to clipboard operation
gateway copied to clipboard

Pluralize backendRefs for non xRoute BackendRef

Open arkodg opened this issue 1 year ago • 12 comments

non xRoute backendRef may need to be pluralized in case we want to handle Active / Standby cases. These are

  • [x] OpenTelemetry https://github.com/envoyproxy/gateway/pull/3293
  • [ ] ext auth https://github.com/envoyproxy/gateway/pull/3469
  • [x] ext proc https://github.com/envoyproxy/gateway/pull/2991

Originally posted by @arkodg in https://github.com/envoyproxy/gateway/issues/3055#issuecomment-2036255077

arkodg avatar Apr 04 '24 06:04 arkodg

ptal @envoyproxy/gateway-maintainers

arkodg avatar Apr 04 '24 06:04 arkodg

+1

guydc avatar Apr 04 '24 11:04 guydc

some more thoughts

  • if we care only about the active and passive use case, another backupBackendRef will suffice
  • If we also want traffic splitting, we'll have to pluralize backendRef

arkodg avatar Apr 04 '24 11:04 arkodg

+1 for this

arkodg avatar Apr 05 '24 07:04 arkodg

I think it's valid for non-k8s deployments, but not necessarily for k8s environment because you normally won't deploy two services for ext auth/ext proc/Telemetry.

zhaohuabing avatar Apr 05 '24 08:04 zhaohuabing

@zhaohuabing even for the K8s there could be a Service local in the cluster and another Service ( on standby ) in another cluster represented as a ServiceImport

arkodg avatar Apr 05 '24 08:04 arkodg

Yah, falling back to a remote cluster is a very persuasive case for me. +1 for this!

zhaohuabing avatar Apr 05 '24 08:04 zhaohuabing

for OpenTelemetry,

  1. accesslog and metric support multi sinks
  2. tracing only support one backend

zirain avatar Apr 05 '24 12:04 zirain

@zirain this is more about endpoint routing for a single request - traffic spitting and priority, rather than sending multiple requests to multiple sinks

arkodg avatar Apr 05 '24 12:04 arkodg

+1

Alice-Lilith avatar Apr 09 '24 15:04 Alice-Lilith

This seems like a good idea, let's do it. 👍

kflynn avatar Apr 09 '24 23:04 kflynn

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

github-actions[bot] avatar May 10 '24 00:05 github-actions[bot]

@zirain is this finished?

shawnh2 avatar May 30 '24 04:05 shawnh2

@zirain afaik we havent yet implemented backendRefs for extAuth, so reopening this issue

arkodg avatar May 30 '24 05:05 arkodg

@zirain afaik we havent yet implemented backendRefs for extAuth, so reopening this issue

It's done in https://github.com/envoyproxy/gateway/pull/3469 or you want to remove the limitation of maxItems=1?

zirain avatar Jun 01 '24 13:06 zirain

I think we can close it now, and create another one to track multi backends for ext_auth.

zirain avatar Jun 05 '24 10:06 zirain