gateway
gateway copied to clipboard
Pluralize backendRefs for non xRoute BackendRef
non xRoute backendRef may need to be pluralized in case we want to handle Active / Standby cases. These are
- [x] OpenTelemetry https://github.com/envoyproxy/gateway/pull/3293
- [ ] ext auth https://github.com/envoyproxy/gateway/pull/3469
- [x] ext proc https://github.com/envoyproxy/gateway/pull/2991
Originally posted by @arkodg in https://github.com/envoyproxy/gateway/issues/3055#issuecomment-2036255077
ptal @envoyproxy/gateway-maintainers
+1
some more thoughts
- if we care only about the active and passive use case, another
backupBackendRefwill suffice - If we also want traffic splitting, we'll have to pluralize backendRef
+1 for this
I think it's valid for non-k8s deployments, but not necessarily for k8s environment because you normally won't deploy two services for ext auth/ext proc/Telemetry.
@zhaohuabing even for the K8s there could be a Service local in the cluster and another Service ( on standby ) in another cluster represented as a ServiceImport
Yah, falling back to a remote cluster is a very persuasive case for me. +1 for this!
for OpenTelemetry,
- accesslog and metric support multi sinks
- tracing only support one backend
@zirain this is more about endpoint routing for a single request - traffic spitting and priority, rather than sending multiple requests to multiple sinks
+1
This seems like a good idea, let's do it. 👍
This issue has been automatically marked as stale because it has not had activity in the last 30 days.
@zirain is this finished?
@zirain afaik we havent yet implemented backendRefs for extAuth, so reopening this issue
@zirain afaik we havent yet implemented
backendRefsfor extAuth, so reopening this issue
It's done in https://github.com/envoyproxy/gateway/pull/3469 or you want to remove the limitation of maxItems=1?
I think we can close it now, and create another one to track multi backends for ext_auth.