gateway icon indicating copy to clipboard operation
gateway copied to clipboard

feat: gRPC Access Log Service (ALS) sink

Open davidalger opened this issue 1 year ago • 10 comments

What this PR does / why we need it:

This PR adds support for configuring a gRPC Access Log Service (ALS) logging sink implementing API added in #3078.

davidalger avatar Mar 29 '24 19:03 davidalger

Codecov Report

Attention: Patch coverage is 67.63485% with 78 lines in your changes are missing coverage. Please review.

Project coverage is 66.56%. Comparing base (9416798) to head (31ace50). Report is 279 commits behind head on main.

Files Patch % Lines
internal/provider/kubernetes/controller.go 31.91% 26 Missing and 6 partials :warning:
internal/provider/kubernetes/indexers.go 28.00% 16 Missing and 2 partials :warning:
internal/xds/translator/accesslog.go 78.57% 14 Missing and 1 partial :warning:
internal/gatewayapi/listener.go 89.33% 6 Missing and 2 partials :warning:
internal/provider/kubernetes/predicates.go 79.16% 5 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3062      +/-   ##
==========================================
+ Coverage   66.54%   66.56%   +0.01%     
==========================================
  Files         157      157              
  Lines       21956    22175     +219     
==========================================
+ Hits        14611    14761     +150     
- Misses       6502     6563      +61     
- Partials      843      851       +8     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 29 '24 20:03 codecov[bot]

/retest

davidalger avatar Mar 29 '24 20:03 davidalger

/retest

davidalger avatar Mar 30 '24 17:03 davidalger

/retest

davidalger avatar Apr 02 '24 23:04 davidalger

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

github-actions[bot] avatar May 03 '24 00:05 github-actions[bot]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

github-actions[bot] avatar Jun 02 '24 08:06 github-actions[bot]

hey @davidalger still working on this one ?

arkodg avatar Jun 04 '24 20:06 arkodg

@davidalger are you still working on this? if not, I can take over this.

zirain avatar Jun 18 '24 08:06 zirain

@arkodg @zirain my apologies on the silent fading into the background on my part. I changed employers last month and have been unable to get back to it and pay the attention due my favorite OSS projects on Github.

the plan was to wrap up #3190 first, although I see it looks like @zirain implemented much of that in another PR, so this could make it along rather nicely now. definitely feel free to pick it up and carry it across the finish line if you'd like to, as at least for the time being I have few spare cycles to spend doing so myself.

davidalger avatar Jun 25 '24 14:06 davidalger

hey np @davidalger, congratulations on the new gig :) looks like @zirain already took the PR forward, so should be okay to close this one, would be great if you can review #3626

arkodg avatar Jun 25 '24 17:06 arkodg

closed in favor of #3626

shawnh2 avatar Jul 03 '24 01:07 shawnh2