gateway icon indicating copy to clipboard operation
gateway copied to clipboard

api: connection limits

Open guydc opened this issue 1 year ago • 1 comments

What this PR does / why we need it: Adds a container for connection-level settings to CTP called Connection. Currently, connection will only support the Limit attribute for setting the max concurrent limits. Limits will be enforced using the Envoy Connection Limit Filter.

When a CTP with a connection limit attaches to a Gateway, each Listener will inherit the parent gateway's limit. This proposal does not deal with Envoy listener runtime connection limits.

In the future, we can consider using this container for #2600, #2670, downstream TCP keepalive, connection local rate limits, ...

Which issue(s) this PR fixes: Relates to #2685

guydc avatar Feb 26 '24 23:02 guydc

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.57%. Comparing base (f52a6f6) to head (a70dba1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2709   +/-   ##
=======================================
  Coverage   64.57%   64.57%           
=======================================
  Files         122      122           
  Lines       21115    21115           
=======================================
  Hits        13636    13636           
  Misses       6632     6632           
  Partials      847      847           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 26 '24 23:02 codecov[bot]

/retest

guydc avatar Mar 05 '24 13:03 guydc

/retest

guydc avatar Mar 05 '24 18:03 guydc

/retest

guydc avatar Mar 13 '24 21:03 guydc

/retest

guydc avatar Mar 14 '24 18:03 guydc

/retest

guydc avatar Mar 14 '24 18:03 guydc

/retest

guydc avatar Mar 15 '24 11:03 guydc

/retest

guydc avatar Mar 15 '24 11:03 guydc