envoy icon indicating copy to clipboard operation
envoy copied to clipboard

reverse_conn: envoy contrib changes for reverse_connection custom cluster

Open basundhara-c opened this issue 10 months ago • 7 comments

Commit Message: This PR defines a new custom cluster type "envoy.clusters.reverse_connection" which enables requests to be sent over reverse connections instead of forward connections. This PR is strictly tied with https://github.com/envoyproxy/envoy/pull/37368.

Additional Description: In order to differentiate between requests that need to be sent via a reverse connection vs those to be sent through forward connections, a new cluster type has been defined. The downstream requests to be sent over reverse connections are expected to contain either of the HTTP headers defined in the cluster's typed config, to enable upstream envoy to figure out which downstream node to send the request to,

The Cluster Manager checks whether the connection is intended for a reverse connection cluster, and if so, calls a custom HTTP/2 conn pool to send the request over the reverse connection. Risk Level: Testing: Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional API Considerations:]

basundhara-c avatar Jan 08 '25 09:01 basundhara-c

Hi @basundhara-c, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/37932 was opened by basundhara-c.

see: more, trace.

/retest

jmarantz avatar Jan 16 '25 14:01 jmarantz

@botengyao anything blocking moving forward with a review?

jmarantz avatar Jan 16 '25 14:01 jmarantz

ping @botengyao

phlax avatar Jan 22 '25 10:01 phlax

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Feb 21 '25 16:02 github-actions[bot]

/wait

@botengyao Is this PR ready to be reviewed again or Is this PR still waiting for https://github.com/envoyproxy/envoy/pull/37368 to land? Thanks!

tyxia avatar May 20 '25 15:05 tyxia

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Jun 19 '25 16:06 github-actions[bot]

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Jun 26 '25 20:06 github-actions[bot]