bump cel-cpp

[asedeno]

trafficstars

Update cel-cpp to HEAD as of when this PR was made, and drop the now-obsolete patches.

https://github.com/google/cel-cpp/commit/f85efd9f06a94c07e9d11f9a9793e690c6e208a1

Risk Level: Testing: CI

[repokitteh-read-only[bot]]

As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/36661 was opened by asedeno.

see: more, trace.

[repokitteh-read-only[bot]]

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch). envoyproxy/dependency-shepherds assignee is @phlax

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/36661 was opened by asedeno.

see: more, trace.

[asedeno]

This PR will complete and obsolete #36167 and #35514. (cc: @kyessenov)

[asedeno]

We've got a gcc build issue; I'm working on fixing that upstream.

[phlax]

@asedeno this (re-) adds a bit of noise to the build

external/com_google_cel_cpp/common/internal/reference_count.cc:83:33: warning: offset of on non-standard-layout type 'cel::common_internal::(anonymous namespace)::ReferenceCountedString' [-Winvalid-offsetof]
    internal::SizedDelete(that, offsetof(ReferenceCountedString, data_) + size);
                                ^                                ~~~~~
/opt/llvm/lib/clang/14.0.0/include/stddef.h:104:24: note: expanded from macro 'offsetof'
#define offsetof(t, d) __builtin_offsetof(t, d)
                       ^                     ~

INFO: From Compiling internal/well_known_types.cc:
In file included from external/com_google_cel_cpp/internal/well_known_types.cc:15:
external/com_google_cel_cpp/internal/well_known_types.h:1133:52: warning: private field 'fields_key_field_string_type_' is not used [-Wunused-private-field]
  google::protobuf::FieldDescriptor::CppStringType fields_key_field_string_type_;

 INFO: From Compiling common/type_factory.cc:
external/com_google_cel_cpp/common/type_factory.cc:25:6: warning: unused function 'IsValidMapKeyType' [-Wunused-function]
bool IsValidMapKeyType(const Type& type) {
     ^
1 warning generated.

can we resolve upstream or failing that patch it out?

[asedeno]

@asedeno this (re-) adds a bit of noise to the build

Working on it now; which specific build(s) did you pull these from? I want to cross-reference against HEAD to see what new warnings have popped up.

[phlax]

iirc the ./ci/do_ci.sh release.test_only in prechecks

[phlax]

https://github.com/envoyproxy/envoy/actions/runs/11391229612/job/31694585390#step:12:583

[asedeno]

The warnings have been resolved (or silenced) upstream.

[asedeno]

/retest