envoy icon indicating copy to clipboard operation
envoy copied to clipboard

1.31 docs missing warning about envoy.filters.http.upstream_codec

Open shulin-sq opened this issue 1 year ago • 1 comments

Title: 1.31 docs missing warning about envoy.filters.http.upstream_codec

Description:

in 1.31 you must configure upstream_codec with a type_config

-          "name": "envoy.filters.http.upstream_codec"
+          "name": "envoy.filters.http.upstream_codec",
+          "typed_config": {
+            "@type": "type.googleapis.com/envoy.extensions.filters.http.upstream_codec.v3.UpstreamCodec"
+          }

likely after this commit https://github.com/envoyproxy/envoy/commit/c1123b5c064e1d99f44c7359469805326b9f811f

but it was not called out in https://www.envoyproxy.io/docs/envoy/latest/version_history/v1.31/v1.31.0

it's an easy fix but just wanted to note it somewhere if anyone else runs into this. I'm not sure if 1.31 docs can be updated at this point?

shulin-sq avatar Aug 23 '24 00:08 shulin-sq

hi - the 1.31.0 docs cant be updated - but we can update them for the next 1.31 patch release

probably we missed the boat adding a changelog but i think we should add something to the upstream_codec documentation

phlax avatar Aug 23 '24 09:08 phlax

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

github-actions[bot] avatar Sep 23 '24 00:09 github-actions[bot]

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

github-actions[bot] avatar Sep 30 '24 04:09 github-actions[bot]