envoy icon indicating copy to clipboard operation
envoy copied to clipboard

router_check: read routes from bootstrap config

Open cainelli opened this issue 1 year ago • 2 comments

Commit Message: router_check: read routes from bootstrap config Additional Description: Support reading from bootstrap configuration and load runtime flags.

Risk Level: Low Testing:

# bootstrap config
router_check_tool --bootstrap-config test/tools/router_check/test/config/ClusterHeaderBootstrap.yaml --test-path test/tools/router_check/test/config/ClusterHeaderBootstrap.golden.proto.json -l main

# router config
router_check_tool --config-path test/tools/router_check/test/config/ClusterHeader.yaml --test-path test/tools/router_check/test/config/ClusterHeader.golden.proto.json

Fixes https://github.com/envoyproxy/envoy/issues/35174

cainelli avatar Aug 10 '24 15:08 cainelli

As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/35662 was opened by cainelli.

see: more, trace.

@adisuissa I also did a small refactor with options (sorry to increase the scope) let me know if it makes sense to keep or if you'd prefer to have as a separate PR . I must also add more tests but before would like to know if this high level approach with separate flag for bootstrap makes sense or you'd prefer a single flag for config, if yes I'd appreciate any pointer how I could do it. see https://github.com/envoyproxy/envoy/pull/35662#discussion_r1716080661

cainelli avatar Aug 18 '24 11:08 cainelli

@cainelli needs a main merge

/wait

phlax avatar Sep 02 '24 15:09 phlax

@adisuissa ping-nag

ravenblackx avatar Sep 10 '24 14:09 ravenblackx

@adisuissa promised to followup on PRs today, but it looks likely to slip to another (business) day.

ravenblackx avatar Sep 13 '24 20:09 ravenblackx

Thank you for following-up @ravenblackx and no worries, I understand and am patience. I appreciate the hard work from all Envoy maintainers :). Please let me know if I can make this any easier to review @adisuissa.

cainelli avatar Sep 13 '24 21:09 cainelli

/wait-any

kyessenov avatar Sep 30 '24 18:09 kyessenov

/wait

Per discussion thread https://github.com/envoyproxy/envoy/pull/35662#discussion_r1794234910, this pr seems to be waiting for the action from the author.

tyxia avatar Oct 15 '24 14:10 tyxia

To be followed-up with a new PR. https://github.com/envoyproxy/envoy/pull/35662#discussion_r1801379721

cainelli avatar Oct 15 '24 15:10 cainelli