envoy icon indicating copy to clipboard operation
envoy copied to clipboard

[Backport 1.28] Fixed bazel configuration ambiguity for non HTTP3 builds (#34483)

Open tedjpoole opened this issue 1 year ago • 4 comments

Back port of #34483 to release/v1.28.

To avoid ambiguity when building with //bazel:http3=False (on PPC and Windows) this commit adds new config_setting_groups and updates the relevant select() statements.

tedjpoole avatar Jun 28 '24 08:06 tedjpoole

I've done #34966 for 1.29 but have no need for 1.27

tedjpoole avatar Jun 28 '24 15:06 tedjpoole

@phlax will this merge once the release/v1.28 branch is reopened, or is there something else I need to do?

tedjpoole avatar Jul 01 '24 09:07 tedjpoole

@tedjpoole apologies i should have landed this before we released - seems like this backport is gtg - i hadnt due to the ci failure on other branch/es

phlax avatar Jul 01 '24 13:07 phlax

@phlax No worries about missing the release. I can cherry pick it for now thanks

tedjpoole avatar Jul 01 '24 14:07 tedjpoole