envoy icon indicating copy to clipboard operation
envoy copied to clipboard

Published 20 hours ago • verified publisher icon envoyproxy

tracer: fix skywalking layer always shows unknown

Open zirain opened this issue 1 year ago • 8 comments

Commit Message: fix skywalking layer always shows unknown Additional Description: Risk Level: Testing: Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional API Considerations:]

zirain avatar May 28 '24 04:05 zirain

/retest

zirain avatar May 28 '24 19:05 zirain

Although the tracer maybe used by other protocols, but, anyway, HTTP is better than unknow. So I am OK to this change for now.

I asked @wu-sheng, he's OK with this change.

zirain avatar May 30 '24 02:05 zirain

/retest

wbpcode avatar May 30 '24 02:05 wbpcode

oh, retest didn't work. Could you kick the CI by an empty commit? Thanks.

/wait

wbpcode avatar May 30 '24 02:05 wbpcode

oh, retest didn't work. Could you kick the CI by an empty commit? Thanks.

/wait

I kicked it with merge main, but seem not working, @phlax can you take a look?

zirain avatar May 30 '24 02:05 zirain

Although the tracer maybe used by other protocols, but, anyway, HTTP is better than unknow. So I am OK to this change for now.

HTTP is used for HTTP 1.x and HTTP2(gRPC included).

wu-sheng avatar May 30 '24 03:05 wu-sheng

ci kicked

phlax avatar May 30 '24 05:05 phlax

Although the tracer maybe used by other protocols, but, anyway, HTTP is better than unknow. So I am OK to this change for now.

HTTP is used for HTTP 1.x and HTTP2(gRPC included).

We have dubbo, and various private protocols. But it's OK for me for now. :)

wbpcode avatar May 30 '24 06:05 wbpcode

kindly ping @wbpcode

zirain avatar Jun 04 '24 03:06 zirain