envoy
envoy copied to clipboard
envoyproxy
Thrift to Metadata filter proto design
Commit Message: For apache thrift compatible HTTP requests and responses, this filter parses the thrift metadata and put them into filter dynamic metadata for other filter usage.
This is the initial proto design, which refers to other filters like json_to_metadata and payload_to_metadata.
Additional Description: Risk Level: low Testing: build Docs Changes: yes Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] #29371 [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional API Considerations:]
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @htuch
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).
:cat:
Caused by: https://github.com/envoyproxy/envoy/pull/33919 was opened by JuniorHsu.
![repokitteh-read-only[bot] avatar](https://avatars.githubusercontent.com/in/16729?v=4 "Published by a pub.dev verified publisher"){kind=small}
@htuch could i have an early api review? the test failure is coverage which is expected
do you want to mark all the protobuf as not yet implemented and move forward with this PR just to get the protobuf API in place
Sure I'll have a very basic unit test to pass the coverage so we can move on the wip filter. Thanks for the great idea.
do you want to mark all the protobuf as not yet implemented
just notice i already set option (xds.annotations.v3.file_status).work_in_progress = true;
@zuercher I addressed all the comments except this https://github.com/envoyproxy/envoy/pull/33919#discussion_r1599303324 which needs some input. Also add some trivial unit test, hopefully pass the coverage test
do you want to mark all the protobuf as not yet implemented
just notice i already set
option (xds.annotations.v3.file_status).work_in_progress = true;
Sorry -- I didn't realize that could be done at the file level vs. per-message.
we got approval and api reviewed so i think we're good to merge. https://github.com/envoyproxy/envoy/pull/33919#pullrequestreview-2072613349