envoy icon indicating copy to clipboard operation
envoy copied to clipboard

Published 20 hours ago • verified publisher icon envoyproxy

Fix: OpenTelemetry access logs: Missing span ID

Open ashishb-90 opened this issue 1 year ago • 9 comments

Commit Message: Fix missing span_id in opentelemetry access log messages Additional Description: Risk Level: Low Testing: Covered by existing tests (see ](https://github.com/envoyproxy/envoy/pull/33909/files#diff-6f359b1fb4a03ceb3f64ed506c57b32b67e06f8dc41f396f6f20c9b4f292e39f)) Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] Fixes https://github.com/envoyproxy/envoy/issues/33906 Fixes https://github.com/envoyproxy/envoy/issues/30268 [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional API Considerations:]

ashishb-90 avatar May 01 '24 14:05 ashishb-90

As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/33909 was opened by ashishb-solo.

see: more, trace.

repokitteh-read-only[bot] avatar May 01 '24 14:05 repokitteh-read-only[bot]

@mmanciop can you advise on whether this fixes https://github.com/envoyproxy/envoy/issues/30268? I thought it did at first glance, but now I'm not completely sure

ashishb-90 avatar May 02 '24 15:05 ashishb-90

@mmanciop can you advise on whether this fixes https://github.com/envoyproxy/envoy/issues/30268? I thought it did at first glance, but now I'm not completely sure

I'll test it out with Dash0 :-)

mmanciop avatar May 02 '24 15:05 mmanciop

@ashishb-solo works pretty nicely :-)

Screenshot 2024-05-03 at 09 32 46

This screenshot is from Dash0, and shows the correlation between logs and spans using the OpenTelemetry demo updated according to the #33925 PR.

mmanciop avatar May 03 '24 06:05 mmanciop

@kyessenov i think this is waiting on further review

phlax avatar May 07 '24 18:05 phlax

@kyessenov Second ping on this waiting for your review.

ravenblackx avatar May 13 '24 15:05 ravenblackx

/wait-any

kyessenov avatar May 20 '24 16:05 kyessenov

@kyessenov I believe all review comments have been addressed. Would you mind re-reviewing when you get a chance? Thanks!!

ashishb-90 avatar May 29 '24 17:05 ashishb-90

I'm a bit confused this this hasn't merged yet. @kyessenov , do you see any issues or things that I still need to resolve?

ashishb-90 avatar May 30 '24 16:05 ashishb-90

cc @adisuissa for final signoff

phlax avatar Jun 05 '24 12:06 phlax

I'm a bit confused this this hasn't merged yet. @kyessenov , do you see any issues or things that I still need to resolve?

Apologies! Assigning Yan as code-owner and senior-maintainer. /assign @yanavlasov

adisuissa avatar Jun 05 '24 13:06 adisuissa