envoy
envoy copied to clipboard
dlb: add how to use
Add doc about how to use.
Commit Message: Additional Description: Risk Level: low Testing: N/A Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional API Considerations:]
/docs
Docs for this Pull Request will be rendered here:
https://storage.googleapis.com/envoy-pr/33818/docs/index.html
The docs are (re-)rendered each time the CI envoy-presubmit (precheck docs) job completes.
/retest
/wait on CI
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @phlax
@adisuissa sorry for mistake :(
still failing format and publishing ci
/wait
Force push to fix DCO.
@phlax please help review :)
/docs
Docs for this Pull Request will be rendered here:
https://storage.googleapis.com/envoy-pr/33818/docs/index.html
The docs are (re-)rendered each time the CI envoy-presubmit (precheck docs) job completes.
@daixiang0 there are a lot of format issues - see https://storage.googleapis.com/envoy-pr/c0fc41e/docs/configuration/other_features/dlb.html
could you resolve these first and then i can review
/wait
@phlax please check the latest, CI is happy.
@daixiang0 please look at the rendered docs - they are obviously not correct
@phlax thanks, now it works.
See https://storage.googleapis.com/envoy-pr/dee68e7/docs/configuration/other_features/dlb.html
@phlax thanks, I have updated all.
Also I see two download button, maybe the framework bug:
Also I see two download button, maybe the framework bug:
looks correct to me here https://storage.googleapis.com/envoy-pr/5112fcc/docs/configuration/other_features/dlb.html
@daixiang0 one thing im trying to understand ...
with DLB does it load balance between multiple upstream clusters? should the example config have multiple clusters?
perhaps i just dont fully understand what it does
with DLB does it load balance between multiple upstream clusters? should the example config have multiple clusters?
perhaps i just dont fully understand what it does
Now Envoy use multi-threads to handle connections, there is only one balance policy called exact balancer.
The DLB connection balancer can balance the connections between the threads at local, but not helpful for upstream clusters.
i see the bug with the duplicating download now - it happens when you have search terms in the url
/wait
@phlax please check #34406
After it merged, I will merge it then there is only a change about sandbox.
CI failure seems relevant. Can you please take a look? /wait
@adisuissa thanks, I have fixed it.
@phlax can you PTAL?
i think this one is waiting on https://github.com/envoyproxy/envoy/pull/34406 (which i likewise need to review)
/wait
actually - just checked - that one already landed
@daixiang0 i just landed a PR which changes the filesystem layout for sandboxes - essentially all of the docs files are now in the example directory itself (and index is autogenerated)
@phlax great job! Auto generate index is so cool!
I have merged it.