envoy icon indicating copy to clipboard operation
envoy copied to clipboard

dlb: add how to use

Open daixiang0 opened this issue 1 year ago • 23 comments

Add doc about how to use.

Commit Message: Additional Description: Risk Level: low Testing: N/A Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional API Considerations:]

daixiang0 avatar Apr 26 '24 08:04 daixiang0

/docs

phlax avatar Apr 26 '24 09:04 phlax

Docs for this Pull Request will be rendered here:

https://storage.googleapis.com/envoy-pr/33818/docs/index.html

The docs are (re-)rendered each time the CI envoy-presubmit (precheck docs) job completes.

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/33818#issuecomment-2078967461 was created by @phlax.

see: more, trace.

/retest

phlax avatar Apr 30 '24 12:04 phlax

/wait on CI

adisuissa avatar Apr 30 '24 21:04 adisuissa

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch). envoyproxy/dependency-shepherds assignee is @phlax

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/33818 was synchronize by daixiang0.

see: more, trace.

@adisuissa sorry for mistake :(

daixiang0 avatar May 07 '24 01:05 daixiang0

still failing format and publishing ci

/wait

phlax avatar May 10 '24 08:05 phlax

Force push to fix DCO.

daixiang0 avatar May 14 '24 02:05 daixiang0

@phlax please help review :)

daixiang0 avatar May 15 '24 02:05 daixiang0

/docs

phlax avatar May 15 '24 11:05 phlax

Docs for this Pull Request will be rendered here:

https://storage.googleapis.com/envoy-pr/33818/docs/index.html

The docs are (re-)rendered each time the CI envoy-presubmit (precheck docs) job completes.

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/33818#issuecomment-2112323957 was created by @phlax.

see: more, trace.

@daixiang0 there are a lot of format issues - see https://storage.googleapis.com/envoy-pr/c0fc41e/docs/configuration/other_features/dlb.html

could you resolve these first and then i can review

phlax avatar May 15 '24 11:05 phlax

/wait

phlax avatar May 17 '24 07:05 phlax

@phlax please check the latest, CI is happy.

daixiang0 avatar May 17 '24 07:05 daixiang0

@daixiang0 please look at the rendered docs - they are obviously not correct

phlax avatar May 17 '24 08:05 phlax

@phlax thanks, now it works.

See https://storage.googleapis.com/envoy-pr/dee68e7/docs/configuration/other_features/dlb.html

daixiang0 avatar May 20 '24 03:05 daixiang0

@phlax thanks, I have updated all.

Also I see two download button, maybe the framework bug: image

daixiang0 avatar May 21 '24 03:05 daixiang0

Also I see two download button, maybe the framework bug:

looks correct to me here https://storage.googleapis.com/envoy-pr/5112fcc/docs/configuration/other_features/dlb.html

phlax avatar May 22 '24 14:05 phlax

@daixiang0 one thing im trying to understand ...

with DLB does it load balance between multiple upstream clusters? should the example config have multiple clusters?

perhaps i just dont fully understand what it does

phlax avatar May 22 '24 14:05 phlax

with DLB does it load balance between multiple upstream clusters? should the example config have multiple clusters?

perhaps i just dont fully understand what it does

Now Envoy use multi-threads to handle connections, there is only one balance policy called exact balancer.

The DLB connection balancer can balance the connections between the threads at local, but not helpful for upstream clusters.

daixiang0 avatar May 23 '24 01:05 daixiang0

i see the bug with the duplicating download now - it happens when you have search terms in the url

phlax avatar May 28 '24 08:05 phlax

/wait

phlax avatar May 28 '24 08:05 phlax

@phlax please check #34406

After it merged, I will merge it then there is only a change about sandbox.

daixiang0 avatar May 29 '24 08:05 daixiang0

CI failure seems relevant. Can you please take a look? /wait

adisuissa avatar Jun 04 '24 12:06 adisuissa

@adisuissa thanks, I have fixed it.

daixiang0 avatar Jun 05 '24 02:06 daixiang0

@phlax can you PTAL?

adisuissa avatar Jun 05 '24 14:06 adisuissa

i think this one is waiting on https://github.com/envoyproxy/envoy/pull/34406 (which i likewise need to review)

/wait

phlax avatar Jun 05 '24 14:06 phlax

actually - just checked - that one already landed

phlax avatar Jun 05 '24 14:06 phlax

@daixiang0 i just landed a PR which changes the filesystem layout for sandboxes - essentially all of the docs files are now in the example directory itself (and index is autogenerated)

phlax avatar Jun 05 '24 14:06 phlax

@phlax great job! Auto generate index is so cool!

I have merged it.

daixiang0 avatar Jun 07 '24 07:06 daixiang0