Envoy windows build for v1.30.1 not working using Windows 2019 Envoy image

[jeromev66]

Envoy windows build for v1.30.1 not working

Envoy v1.30.1 not working on windows using Windows 2019 Envoy image, using this : https://github.com/envoyproxy/envoy/tree/main/ci#on-windows

Windows build is working perfectly fine on 1.29.4

ERROR: C:/source/source/server/BUILD:13:17: Compiling source/server/backtrace.cc failed: (Exit 2): cl.exe failed: error executing command (from target //source/server:backtrace_lib) 
  cd /d C:/build/tmp/execroot/envoy
  SET INCLUDE=C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.29.30133\include;C:\Program Files (x86)\Windows Kits\10\include\10.0.22000.0\ucrt;C:\Program Files (x86)\Windows Kits\10\include\10.0.22000.0\shared;C:\Program Files (x86)\Windows Kits\10\include\10.0.22000.0\um;C:\Program Files (x86)\Windows Kits\10\include\10.0.22000.0\winrt;C:\Program Files (x86)\Windows Kits\10\include\10.0.22000.0\cppwinrt
    SET PATH=C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.29.30133\bin\HostX64\x64;C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\Common7\IDE\VC\VCPackages;C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\Common7\IDE\CommonExtensions\Microsoft\TestWindow;C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\Common7\IDE\CommonExtensions\Microsoft\TeamFoundation\Team Explorer;C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\MSBuild\Current\bin\Roslyn;C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\Common7\Tools\devinit;C:\Program Files (x86)\Windows Kits\10\bin\10.0.22000.0\x64;C:\Program Files (x86)\Windows Kits\10\bin\x64;C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\\MSBuild\Current\Bin;C:\Windows\Microsoft.NET\Framework64\v4.0.30319;C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\Common7\IDE\;C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\Common7\Tools\;;C:\Windows\system32
    SET PWD=/proc/self/cwd
    SET TEMP=C:\Windows\Temp
    SET TMP=C:\Windows\Temp
    SET TMPDIR=C:\Windows\Temp
    SET USE_CLANG_CL=
    SET VSLANG=1033
  C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.29.30133\bin\HostX64\x64\cl.exe @bazel-out/x64_windows-opt/bin/source/server/_objs/backtrace_lib/backtrace.obj.params
# Configuration: 12d156608f7fe9e40ad4be70ab36e3dd572110f44ea559e047ff53fdf7f95275
# Execution platform: @local_config_platform//:host
source/server/backtrace.cc(12): error C2760: syntax error: unexpected token '#', expected 'statement'
source/server/backtrace.cc(12): error C2065: 'ifndef': undeclared identifier
source/server/backtrace.cc(12): error C2059: syntax error: 'constant'
source/server/backtrace.cc(12): error C2065: 'maps': undeclared identifier
source/server/backtrace.cc(12): error C2059: syntax error: '#'
source/server/backtrace.cc(12): error C2059: syntax error: '('
source/server/backtrace.cc(12): error C2059: syntax error: 'return'
source/server/backtrace.cc(12): error C2059: syntax error: 'while'
source/server/backtrace.cc(32): error C2059: syntax error: '}'
source/server/backtrace.cc(32): error C2143: syntax error: missing ';' before '}'
source/server/backtrace.cc(34): error C2653: 'BackwardsTrace': is not a class or namespace name
source/server/backtrace.cc(34): error C2143: syntax error: missing ';' before '{'
source/server/backtrace.cc(34): error C2447: '{': missing function header (old-style formal list?)
source/server/backtrace.cc(36): error C2059: syntax error: '}'
source/server/backtrace.cc(36): error C2143: syntax error: missing ';' before '}'
Target //source/exe:envoy-static failed to build

[wbpcode]

cc @keith

[phlax]

@jeromev66, repasting what i have posted elsewhere ...

windows is no longer supported by the project as it was mostly unused, came with a very high CI cost and was adding a lot of burden to devs.

we are however open to fixes to make things work and if there is a community of users that rely on this would encourage setting up a downstream project to track Envoy changes.

we probably need to update the docs to reflect that its no longer supported - we only removed the ci itself initially.

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

[github-actions[bot]]

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.