envoy icon indicating copy to clipboard operation
envoy copied to clipboard

deps: update cel, absl, googleapis

Open kyessenov opened this issue 1 year ago • 10 comments

Commit Message: update CEL and its dependencies Additional Description: Risk Level: low Testing: regression

kyessenov avatar Mar 18 '24 22:03 kyessenov

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch). envoyproxy/dependency-shepherds assignee is @phlax

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/32962 was opened by kyessenov.

see: more, trace.

Looks like the mobile build is broken somehow?

RyanTheOptimist avatar Mar 18 '24 23:03 RyanTheOptimist

It looks like a problem in uri_template_test.cc https://dev.azure.com/cncf/envoy/_build/results?buildId=165343&view=logs&j=8c169225-0ae8-53bd-947f-07cb81846cb5&t=d1a98671-b7ba-5fbf-f06c-ff337c010df4&l=701

Hopefully it would need gtest update too.

/wait

yanavlasov avatar Mar 25 '24 19:03 yanavlasov

I've tried to bump Google test - no luck. I'll fix the test directly and keep Google test bump - which seems like a good thing to have.

kyessenov avatar Mar 25 '24 21:03 kyessenov

Undid googletest bump - that breaks something else, without fixing the build failure.

kyessenov avatar Mar 26 '24 20:03 kyessenov

Oh mad, this is difficult. It looks like for gcc failure we will need to patch protobuf. Not sure about the mobile build errors.

yanavlasov avatar Mar 27 '24 16:03 yanavlasov

/wait

for CI

soulxu avatar Apr 02 '24 05:04 soulxu

@kyessenov im thinking this should probably wait until after our next release as its getting close

phlax avatar Apr 02 '24 13:04 phlax

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar May 02 '24 16:05 github-actions[bot]

The mobile failures appear to be in the base Envoy due to C++17 compiler flag. I think we can park this PR until mobile switches over to C++20 so that we don't have to bifurcate the code.

kyessenov avatar May 09 '24 20:05 kyessenov

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Jun 13 '24 16:06 github-actions[bot]

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Jun 20 '24 16:06 github-actions[bot]