envoy icon indicating copy to clipboard operation
envoy copied to clipboard

Published 20 hours ago • verified publisher icon envoyproxy

[ZK filter] Add missing operation supports for multi opcode

Open Winbobob opened this issue 1 year ago • 1 comments

Commit Message: [ZK filter] Add missing operation supports for multi opcode Additional Description: The ZK filter did not support some operations for the multi opcode based on the ZK source code. This could lead to decode errors. This PR tries to fill this gap. Risk Level: Low Testing: Unit tests Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A

Winbobob avatar Feb 18 '24 06:02 Winbobob

cc @JuniorHsu, please review if you have a chance, thank you!

Winbobob avatar Feb 20 '24 15:02 Winbobob

only one nits. I'm going to urge you to express what OP code is supported by this PR instead of one single link in the description

Just updated the desc with more details and addressed your comments, PTAL!

Winbobob avatar Feb 28 '24 05:02 Winbobob

/retest

Winbobob avatar Feb 29 '24 05:02 Winbobob