envoy icon indicating copy to clipboard operation
envoy copied to clipboard

[WIP] deps: Bump `com_github_fmtlib_fmt` -> 10.2.1

Open dependency-envoy[bot] opened this issue 1 year ago • 5 comments

Created by Envoy dependency bot for @phlax

Fix #31663

Signed-off-by: dependency-envoy[bot] <148525496+dependency-envoy[bot]@users.noreply.github.com>

dependency-envoy[bot] avatar Jan 23 '24 11:01 dependency-envoy[bot]

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch). envoyproxy/dependency-shepherds assignee is @htuch

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/31962 was opened by dependency-envoy[bot].

see: more, trace.

Legit failure https://dev.azure.com/cncf/envoy/_build/results?buildId=160405&view=logs&j=5b1da4ae-91c5-53b4-2dce-4cdfc8f90e84&t=f30788fd-b316-5c76-fa87-c77f9b4e50ec

htuch avatar Jan 23 '24 22:01 htuch

Legit failure

yeah - i looked at this before - i think the fix is ~easy but a bit beyond my current understanding - ill look again

phlax avatar Jan 24 '24 07:01 phlax

Can probably just follow https://fmt.dev/latest/api.html#formatting-user-defined-types and provides a format_as with fmt::underlying for HeaderType in https://github.com/envoyproxy/envoy/blob/d15fee54dbebc8acc7781374d0189f402d87db8e/contrib/sip_proxy/filters/network/source/metadata.cc#L180.

htuch avatar Jan 25 '24 23:01 htuch

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Feb 25 '24 00:02 github-actions[bot]

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Mar 03 '24 04:03 github-actions[bot]