envoy icon indicating copy to clipboard operation
envoy copied to clipboard

docs: fix listener filter order in best practice envoy config

Open levimm opened this issue 3 years ago • 3 comments

Commit Message: doc fix about the listener filter order in best practice example

Additional Description: Proxy protocol listener filter should be ahead of tls_inspector listener filter. See this issue for more context: https://github.com/envoyproxy/envoy/issues/23205

Risk Level: Low

Testing: Manual testing with envoy 1.22.2

Docs Changes: yes

Release Notes: N/A Platform Specific Features: N/A [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional API Considerations:]

levimm avatar Sep 23 '22 06:09 levimm

Docs for this Pull Request will be rendered here:

https://storage.googleapis.com/envoy-pr/23217/docs/index.html

The docs are (re-)rendered each time the CI envoy-presubmit (precheck docs) job completes.

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/23217 was opened by levimm.

see: more, trace.

Hi @levimm, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/23217 was opened by levimm.

see: more, trace.

thanks for fixing this, LGTM

/assign @phlax

soulxu avatar Sep 23 '22 06:09 soulxu

/retest

phlax avatar Sep 23 '22 10:09 phlax

Retrying Azure Pipelines: Retried failed jobs in: envoy-presubmit

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/23217#issuecomment-1256032024 was created by @phlax.

see: more, trace.