[backport][release/v1.23] connection handler: correct the handling of listener update

[soulxu]

Signed-off-by: He Jie Xu [email protected]

Commit Message: connection handler: correct the handling of listener update Additional Description: This is cherry-pick from https://github.com/envoyproxy/envoy/pull/22622

Risk Level: high Testing: unittest added Docs Changes: n/a Release Notes: an item for bug fixes added. Fixes https://github.com/envoyproxy/envoy/issues/22449

[soulxu]

/assign @phlax @mattklein123

[phlax]

@soulxu as mentioned previously should this not be raised against main first ?

[soulxu]

@phlax yea, this is cherry pick from https://github.com/envoyproxy/envoy/pull/22622

[phlax]

cool - i just saw that this has landed on main already - apologies for noise (i have been off the last couple of days)

[soulxu]

no worries! thanks for reminder this for me

[soulxu]

/retest

[repokitteh-read-only[bot]]

Retrying Azure Pipelines: Retried failed jobs in: envoy-presubmit

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/22642#issuecomment-1211401322 was created by @soulxu.

see: more, trace.

[soulxu]

@phlax do you know why arm ci failed? it is missing some linux header file for iouring, that is strange.

[soulxu]

/retest

[repokitteh-read-only[bot]]

Retrying Azure Pipelines: Retried failed jobs in: envoy-presubmit

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/22642#issuecomment-1211517816 was created by @soulxu.

see: more, trace.

[phlax]

/retest (for retest purposes)

i tried manually triggering and CI failed again for same reason

@phlax do you know why arm ci failed?

no - seems odd - and unrelated to PR - also wondering why it didnt trigger this on main

[repokitteh-read-only[bot]]

Retrying Azure Pipelines: Retried failed jobs in: envoy-presubmit

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/22642#issuecomment-1211651064 was created by @phlax.

see: more, trace.

[phlax]

/retest

[repokitteh-read-only[bot]]

Retrying Azure Pipelines: Retried failed jobs in: envoy-presubmit

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/22642#issuecomment-1211662900 was created by @phlax.

see: more, trace.

[soulxu]

/retest

[repokitteh-read-only[bot]]

Retrying Azure Pipelines: Retried failed jobs in: envoy-presubmit

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/22642#issuecomment-1212609141 was created by @soulxu.

see: more, trace.

[phlax]

@soulxu searching on this bug and related to liburing and it seems its a kinda common problem with a few potential causes

• missing kernel headers
• incompatible kernel version
• problematic include paths

not sure why it is only failing on arm and only on this envoy version, and only once your patch is applied

im thinking we should probably debug to check kernel version and presence of headers etc

[jmarantz]

/wait

[soulxu]

/retest

Is https://github.com/envoyproxy/envoy/pull/22744 fix the CI issue? give a try

[repokitteh-read-only[bot]]

Retrying Azure Pipelines: Retried failed jobs in: envoy-presubmit

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/22642#issuecomment-1218809362 was created by @soulxu.

see: more, trace.

[phlax]

Is https://github.com/envoyproxy/envoy/pull/22744 fix the CI issue? give a try

i think you will need to merge the branch update as i dont think ci merges as it does on main

[soulxu]

Is #22744 fix the CI issue? give a try

i think you will need to merge the branch update as i dont think ci merges as it does on main

just done, thanks!