envoy
envoy copied to clipboard
deps: Bump `rules_foreign_cc` -> 0.9.0
Fix #22529
Signed-off-by: Ryan Northey [email protected]
Commit Message: Additional Description: Risk Level: Testing: Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional API Considerations:]
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @RyanTheOptimist
/retest
Retrying Azure Pipelines: Check envoy-presubmit isn't fully completed, but will still attempt retrying. Retried failed jobs in: envoy-presubmit
failing with:
ragel/Makefile.am:2: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
make: *** [Makefile:343: /b/f/w/external/net_colm_open_source_ragel/Makefile.in] Error 1
https://dev.azure.com/cncf/envoy/_build/results?buildId=114223&view=logs&j=b7634614-24f3-5416-e791-4f3affaaed6c&t=21e6aa7d-f369-5abd-5e4e-e888cac18e9c&l=231
I somehow missed this PR. Sorry for the delay. I think you'll need an admin to merge it though, since clang-tidy is failing.
/assign @mattklein123
@mattklein123 do you have the super powers to merge this? (or feedback that we should do something to avoid needing a force merge?)
Are we sure this isn't going to perma fail clang-tidy? I don't quite understand what is going on here. cc @keith
/wait-any
i think the failure is genuine - best not to merge until we have figured out what is going on
it looks to me like this log might be omitting the actual failure, does it repro locally?
does it repro locally?
not sure, i didnt try
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!