Enrich proxy spans with filter data

[jcchavezs]

I was looking at envoy traces generated both when you run a filter and when you don’t and I see traces are pretty much the same except for the fact that when a filter blocks a request, no upstream_cluster/upstream_cluster.name is set (which makes sense). Also there is no clue on the duration of the filter execution (at least in traces) which keeps you blind about the duration of the filter execution. Finally, AFAIU filters have no way to access the current span to set attributes or annotations (e.g. modsecurity won’t tell you what rule caused the blocking).

In summary what I’d like to see as outcome would be:

• traces display filter duration either as annotations in the trace (subspans might be overkilling I think) filters can enrich span attributes
• Have an attribute about which filter blocked the request.

In the future I'd like it to be included in the WASM ABI too.

[wbpcode]

traces display filter duration either as annotations in the trace (subspans might be overkilling I think) filters can enrich span attributes

Sound great. But it would bring some additional overhead. 🤔

Have an attribute about which filter blocked the request.

May be response flag or response detail string is better for this requirement?

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

[github-actions[bot]]

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

[jcchavezs]

This issue has been closed by a bot with zero context about the status nor use case.

[phlax]

it was closed due to inactivity - i can reopen it now - but you will need to either implement this yourself, or find someone willing to do so, as well as get it approved

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

[github-actions[bot]]

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.