gcp_authn: Add the doc and release note for gcp_authn_filter

[tyxia]

Signed-off-by: Tianyu Xia [email protected]

[repokitteh-read-only[bot]]

As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/21536 was opened by tyxia.

see: more, trace.

[phlax]

/docs

[repokitteh-read-only[bot]]

Docs for this Pull Request will be rendered here:

https://storage.googleapis.com/envoy-pr/21536/docs/index.html

The docs are (re-)rendered each time the CI envoy-presubmit (precheck docs) job completes.

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/21536#issuecomment-1147461421 was created by @phlax.

see: more, trace.

[repokitteh-read-only[bot]]

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/). envoyproxy/api-shepherds assignee is @markdroth CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/). CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch). envoyproxy/dependency-shepherds assignee is @phlax

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/21536 was synchronize by tyxia.

see: more, trace.

[tyxia]

/unassign @markdroth

No API change, added the API reviewer by mistake (rebase command)

[phlax]

if you rebase to upstream/main and force push it should resolve the merge mash

[tyxia]

if you rebase to upstream/main and force push it should resolve the merge mash

Thank you for early review(I meant to sent out as WIP draft) and hints! For the merge mess, I was trying Github UI suggested edit feature which caused the DCO sign-off error and then I followed the suggested instruction which then caused the merge mess here :(. It should be resolved now other than expanded participants (i.e., expanded noise...), which I am not sure how to/if possible to remove.

Also, I am addressing your review comments and updating doc with latest feature. I will switch it to ready for review when that is done.

[phlax]

Thank you for early review

np, just letting you know that its ok to force-push on a WIP PR - all my reviews have been on the basis of it being WIP

re merge mash - its a pita 8/ and it flags loads of things (and people 8/) unneessarily - so was just clarifying how to resolve

[tyxia]

/retest

[repokitteh-read-only[bot]]

Retrying Azure Pipelines: Retried failed jobs in: envoy-presubmit

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/21536#issuecomment-1172975703 was created by @tyxia.

see: more, trace.

[phlax]

@tyxia could you merge main and ill review again

/wait

[phlax]

@tyxia if you can merge main i would be happy to review again

[tyxia]

thanks for working on this @tyxia

overall i would try to simplify the config any way we can - ie remove any defaults if they are not specifically documented in the text

im wondering about using ip6 here - all of the other examples use ip4 so i would suggest using that if possible (maybe we should default to ip6 but i think it needs to be consistent)

we dont enforce line length for rst but having very long lines makes it harder to review and change so i would split some of the lines (if there is no blank line in between they will be run together anyway)

Thank you very much for the thorough review, @phlax. Those configurations are just dumped from my integration tests and I didn't modify any fields by hand. I will try to simplify them. Also, I will address the other review comments later.

[github-actions[bot]]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

[phlax]

i think not stale

[tyxia]

Thanks for working on this. Does this mean this work is now complete? If so, please add a release note.

Thanks for the review, Adi! Yes, it has been used by several customers already. I have added the release note. PTAL, thanks!

[tyxia]

Thanks! Looks good overall, left a couple of minor comments.

Thanks for the review! PTAL

[tyxia]

/retest

[repokitteh-read-only[bot]]

Retrying Azure Pipelines: Retried failed jobs in: envoy-presubmit

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/21536#issuecomment-1239495858 was created by @tyxia.

see: more, trace.

[tyxia]

/retest

[repokitteh-read-only[bot]]

Retrying Azure Pipelines: Retried failed jobs in: envoy-presubmit

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/21536#issuecomment-1240977287 was created by @tyxia.

see: more, trace.

[adisuissa]

@phlax for a final pass and merge

[tyxia]

Thanks @tyxia - couple of nits and then should be gtm

Thank you for review! I have addressed your comment. PTAL.

The CI failure should not to be related to PR itself. Hopefully the retest could resolve it.

[tyxia]

/retest

[repokitteh-read-only[bot]]

Retrying Azure Pipelines: Retried failed jobs in: envoy-presubmit

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/21536#issuecomment-1257202886 was created by @tyxia.

see: more, trace.