dots-hyprland
dots-hyprland copied to clipboard
end-4
add vpn toggle to sidebarRight and vpn status icon to bar
Describe your changes
adds a VPN toggle to sidebarRight and a VPN status icon to the bar only visible if Proton VPN is installed (by checking if the protonvpn-app command exists) only disconnecting from the VPN is supported as disconnecting (from a VPN interface created by the Proton VPN app) makes the VPN interface disappear completely and since there can be multiple VPN interfaces
Is it ready?
seems to be
ERROR: Failed to load configuration ERROR: caused by @shell.qml[62:96]: Type Bar unavailable ERROR: caused by @modules/bar/Bar.qml[92:21]: Type BarContent unavailable ERROR: caused by @modules/bar/BarContent.qml[406:5]: Syntax error
Actually, doesn't the Proton app already provide a tray icon with "Quick connect" and "Disconnect" options? Wouldn't another indicator on the bar be redundant? And the toggle only being able to disconnect doesn't feel right
Actually, doesn't the Proton app already provide a tray icon with "Quick connect" and "Disconnect" options? Wouldn't another indicator on the bar be redundant?
yes, however with the tray being a dropdown now, you don't see if you're connected or not immediately, and its just nice to have it more integrated in the system
And the toggle only being able to disconnect doesn't feel right
its a limitation, since there can be multiple VPN interfaces and in the case of the Proton VPN interface, once you disconnect, the interface completely disappears
yes, however with the tray being a dropdown now, you don't see if you're connected or not immediately
it's configurable, you can pin proton's item
It already supports wireguard but it will only show up if proton VPN is installed
I would not consider a button that only turns off a toggle button Either we make this somehow be able to turn on or we not have this button
I'm a bit curious that if the button could be dynamically hidden when the state is off.
My suggestion is that the toggle-on behavior should be configurable, i.e. running a user defined command. And if user has not configured it, hide the button when not clickable (i.e. when state is off).
hiding the button is dynamically is possible, and configuring a custom command to run is possible as well, not sure what @end-4 thinks about this though
A button which you can only click to make it disappear is not a toggle button, that's why I don't like this Maybe we can have some different place, or an extra island for such buttons
It already supports wireguard but it will only show up if proton VPN is installed
Only if proton VPN is installed? You might want it check for if there is a wireguard configuration OR proton VPN is installed.
Hi, I'm looking forward for this feature but I have created my VPN configurations manually via NetworkManager, can't we make this more generic, not only for Proton ? Like WireGuard and OpenVPN3 configs aswell ? Is there any way I could contribute for this feature without creating own fork or something ?
The feature already has WireGuard and OpenVPN configurations in mind. The developer has decided to only enable the status icon if Proton VPN is installed.
The feature already has WireGuard and OpenVPN configurations in mind. The developer has decided to only enable the status icon if Proton VPN is installed.
Well that seems stupid. Why not change the dependency to wireguard or openvpn rather than proton vpn.
I thought you wanted to make a Proton-only toggle so I told you to have that constraint
no, i wanted to made it for wireguard and openvpn itself, its just that i was using proton VPN